Skip to content

Conversation

@avivkeller
Copy link
Member

I made the silly little mistake of not setting the PAT 🤦

Copilot AI review requested due to automatic review settings August 4, 2025 23:18
@avivkeller avivkeller requested a review from a team as a code owner August 4, 2025 23:18
@vercel
Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
api-docs-tooling ✅ Ready (Inspect) Visit Preview Aug 4, 2025 11:22pm

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a CI workflow configuration by replacing the default GitHub token with a Personal Access Token (PAT) for updating internal dependencies.

  • Updates the GitHub token reference from the default GITHUB_TOKEN to a custom DOC_KIT_PAT secret

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Aug 4, 2025
@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.27%. Comparing base (fa2e7e2) to head (4411b88).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files         118      118           
  Lines       11041    11041           
  Branches      695      695           
=======================================
  Hits         8201     8201           
  Misses       2837     2837           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller avivkeller marked this pull request as draft August 4, 2025 23:19
@avivkeller
Copy link
Member Author

@legendecas "Error: Resource not accessible by personal access token"

@avivkeller avivkeller removed the fast track This PR can land before the typical review time, with a :+1: from collaborators label Aug 4, 2025
@avivkeller
Copy link
Member Author

Perhaps the token also needs Pull Request permissions?
https://github.com/nodejs/doc-kit/tree/upgrade-node-core-deps

@avivkeller avivkeller marked this pull request as ready for review August 4, 2025 23:23
@avivkeller
Copy link
Member Author

Oh wait, nevermind, I believe the error is because the PAT is including this PR's commits in it's changeset, which requires actions permissions.

cc @nodejs/web-infra fast track

@legendecas
Copy link
Member

Perhaps the token also needs Pull Request permissions? https://github.com/nodejs/doc-kit/tree/upgrade-node-core-deps

yes, if it writes a PR. Please submit an amendment to the admin repo for new permissions.

@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Aug 4, 2025
@avivkeller
Copy link
Member Author

I think, as I mentioned above, it's lacking actions permissions (which, it doesn't need), so it should resolve itself once this PR lands. If it still doesn't work, it needs pull-request permissions, to which I'll open a follow-up in admin

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it'll need the PR permission, but this needs to land either way

@avivkeller avivkeller merged commit d64152e into main Aug 4, 2025
18 of 19 checks passed
@avivkeller avivkeller deleted the PAT branch August 4, 2025 23:29
@avivkeller
Copy link
Member Author

Pretty sure it'll need the PR permission, but this needs to land either way

Indeed, 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants