-
Notifications
You must be signed in to change notification settings - Fork 24
fix(ci): use PAT #387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): use PAT #387
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a CI workflow configuration by replacing the default GitHub token with a Personal Access Token (PAT) for updating internal dependencies.
- Updates the GitHub token reference from the default
GITHUB_TOKENto a customDOC_KIT_PATsecret
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #387 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 118 118
Lines 11041 11041
Branches 695 695
=======================================
Hits 8201 8201
Misses 2837 2837
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@legendecas "Error: Resource not accessible by personal access token" |
|
Perhaps the token also needs Pull Request permissions? |
|
Oh wait, nevermind, I believe the error is because the PAT is including this PR's commits in it's changeset, which requires cc @nodejs/web-infra fast track |
yes, if it writes a PR. Please submit an amendment to the admin repo for new permissions. |
|
I think, as I mentioned above, it's lacking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure it'll need the PR permission, but this needs to land either way
Indeed, 🤦 |
I made the silly little mistake of not setting the PAT 🤦